[ALOY-332] Improve TabGroup creation
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Low |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-07-31T21:32:14.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.3.0 |
| Components | XML |
| Labels | n/a |
| Reporter | Tony Lukasavage |
| Assignee | Tony Lukasavage |
| Created | 2012-10-12T20:45:18.000+0000 |
| Updated | 2013-10-11T22:34:27.000+0000 |
Description
The TabGroup collection of Tabs os being created via repeated use of the
addTab() function. Ideally we'd rather be creating an array of Tabs and assigning that to the TabGroup's tabs property at creation time. This works on iOS, but unfortunately fails with nothing but a black screen on Android and Mobileweb.
WIll address this once TIMOB-11434 is resolved.
Dependency resolved in TIMOB-11434. Will write conditional compilation code to ensure that the faster, array-driven tabgrouop composition is used for iOS, as well as Android and MW 3.1.0+.
PR: https://github.com/appcelerator/alloy/pull/199 test app: https://github.com/appcelerator/alloy/tree/master/test/apps/ui/tabgroup Functional testing can be confirmed by successfully running the given test app on all supported platforms without error. On Blackberry, there are a lot of missing components (like tab and window titles), but as long as it shows a 2-tabbed app it is good.
Verified working as expected. Alloy 1.3.0 CLI 3.2.0 TiSDK 3.2.0.v20131010163242 Titanium Studio 3.1.4 Closing.