[ALOY-434] Styles in platform-specific and theme folders should be merged, not completely overwrite base styles
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2014-08-06T19:14:20.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.1.0, 2013 Sprint 06 |
| Components | XML |
| Labels | notable, qe-automatedtest, qe-manualtest |
| Reporter | Tony Lukasavage |
| Assignee | Tony Lukasavage |
| Created | 2012-12-19T17:10:40.000+0000 |
| Updated | 2014-08-06T19:14:20.000+0000 |
Description
update (3/21/2013)
Both platform-specific styles and theme styles will now merge, not overwrite, any existing generic styles. They will merge in the following order, from lowest to highest precedence:generic styles
theme styles
platform-specific generic styles
platform-specific theme styles
The themes test app in the github repo will be modified to show this behavior: https://github.com/appcelerator/alloy/tree/master/test/apps/advanced/themesoriginal
Styles housed in the platform-specific folders currently overwrite non-platform-specific styles relevant to the same runtime controller. Instead of wholely overwriting these styles, the platform-specific style should merge with any existing styles, just as it does with device queries in the TSS files themselves. This will allow developers to write more concise platform-specific styles without having to recreate the whole style.Comments
- Federico Casali 2013-04-09 Verified fixed. Alloy: 1.1.0-cr CLI version 3.1.0-cr TiSDK: 3.1.0.v20130408154547 (RC) Android and iOS devices. Closing.
- Federico Casali 2014-08-06 Reopening for updating 'tester' field, labels and log time.