Titanium JIRA Archive
Alloy (ALOY)

[ALOY-457] Make Alloy sync adapter sync() function signature match that of Backbone

GitHub Issuen/a
TypeBug
PriorityHigh
StatusResolved
ResolutionFixed
Resolution Date2013-01-23T16:46:07.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.0.0, 2013 Sprint 02
ComponentsRuntime
Labelsn/a
ReporterTony Lukasavage
AssigneeUnknown
Created2013-01-14T11:26:58.000+0000
Updated2018-03-07T22:26:14.000+0000

Description

Right now the sync function for custom sync adapters is as follows:
function Sync(model, method, opts) {
// ...
}
but as David Yang points out in this PR: https://github.com/appcelerator/alloy/pull/86 The order should be (method, model, opts):
function Sync(method, model, opts) {
// ...
}
We need to change the order these are processed in the runtime alloy.js file, as well as in all Alloy's supported sync adapters. In addition, we will need to communicate this change to the community as it will break existing sync adapters. As this is a breaking change, it will need to go in before the 1.0.0 release of Alloy.

Comments

No comments

JSON Source