[ALOY-477] Remove rhino support workaround (ups the threadstacksize)
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Low |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-07-31T21:31:33.000+0000 |
| Affected Version/s | Alloy 1.0.0 |
| Fix Version/s | Alloy 1.3.0 |
| Components | Titanium SDK |
| Labels | n/a |
| Reporter | Tony Lukasavage |
| Assignee | Tony Lukasavage |
| Created | 2013-01-21T22:00:37.000+0000 |
| Updated | 2013-12-10T18:18:09.000+0000 |
Description
To allow Alloy to work with the android rhino engine, and not fail with "too deep recursion" as in ALOY-340, we needed to add an element to the tiapp.xml that tells android to increase its thread stack size. Alloy checks for this element in the compile step and adds it if it is not present.
With Titanium 3.1, rhino support will be dropped. At this point we should delete the code that adds the increased thread stack size to all alloy android projects.
PR: https://github.com/appcelerator/alloy/pull/199 Functional testing on Android (tiapp.xml reference|[https://wiki.appcelerator.org/display/guides2/tiapp.xml+and+timodule.xml+Reference#tiapp.xmlandtimodule.xmlReference-Androidspecificapplicationproperties]):
Create a default alloy app
Confirm or change the following in the tiapp.xml
** A 3.0.x TiSDK version is selected ** The "rhino" runtime is added ** there is no existing entry for ti.android.threadstacksizeRun the app for android
Ensure that Alloy added the ti.android.threadstacksize entry to the tiapp.xml to facilitate use with the rhino runtime.
Rhino is no longer supported, Alloy 1.3.0 requires TiSDK 3.2.0, workaround is no longer relevant. Also unit test are passing. Closing.