[ALOY-577] Theme assets not removed in orphan file cleanup
| GitHub Issue | n/a |
|---|
| Type | Bug |
|---|
| Priority | Medium |
|---|
| Status | Closed |
|---|
| Resolution | Fixed |
|---|
| Resolution Date | 2014-06-02T21:27:50.000+0000 |
|---|
| Affected Version/s | Alloy 1.4.0 |
|---|
| Fix Version/s | Alloy 1.2.0, 2013 Sprint 15 |
|---|
| Components | Styling |
|---|
| Labels | qe-testadded, regression |
|---|
| Reporter | Thomas Neerup |
|---|
| Assignee | Tony Lukasavage |
|---|
| Created | 2013-03-08T06:39:19.000+0000 |
|---|
| Updated | 2014-06-02T21:27:54.000+0000 |
|---|
Description
Steps to Reproduce
When using Alloy with themes, the asset folder in the theme overrides the main asset folder as it should, but when changing theme, and the new theme does not have the same overrides as the last themes used, You find yourself with a mix of assets from the old and the new theme.
Actual Result
Oldt themes overrides still exists in the resources folder, wuth the new ones
Expected Result
When changing theme, the resources folder should be cleared, so all files from old theme is removed.
Attachments
PR: https://github.com/appcelerator/alloy/pull/195 test app: https://github.com/appcelerator/alloy/tree/master/test/apps/testing/ALOY-577 Functional testing should do the following:
Run the test app. The initial theme is "red" so you should see a red background color with 2 images. The top image should be a red [bokeh](http://en.wikipedia.org/wiki/Bokeh) image with the Alloy logo under it.
Open the config.json file and change the theme to "blue"
Run the app again. You should see a blue background color with 2 images. The top image should be the Alloy logo with the second blue swirl image under it.
Open the config.json and remove the theme entirely
Run the app again. You should see 2 alloy logos. Prior to this fix, one or both of the red and blue images would still be there.
*NOTE:* This fix introduces an alloy build log file which makes use of the project's build folder. As a simple additional validation, do the following:create a new alloy project
delete the project's "build" folder
compile alloy or do a full build
Ensure that the absence of a "build" folder is handled gracefully by alloy, meaning that no errors are generated and the build executes as expected.
Verified as fixed on iOS, Android and MobileWeb. Titanium SDK 3.1.2.v20130802180729 Alloy 1.2.0-alpha6 Appcelerator Studio 3.1.2.201308021524 CLI 3.1.1 Node 0.10.13 Closing.