[ALOY-588] Implement and test isTablet and isHandheld functions for Blackberry
| GitHub Issue | n/a |
|---|
| Type | Improvement |
|---|
| Priority | High |
|---|
| Status | Closed |
|---|
| Resolution | Fixed |
|---|
| Resolution Date | 2013-07-24T16:34:21.000+0000 |
|---|
| Affected Version/s | n/a |
|---|
| Fix Version/s | Alloy 1.2.0, 2013 Sprint 15 |
|---|
| Components | Runtime, Styling |
|---|
| Labels | qe-testadded |
|---|
| Reporter | Tony Lukasavage |
|---|
| Assignee | Tony Lukasavage |
|---|
| Created | 2013-03-26T17:10:53.000+0000 |
|---|
| Updated | 2013-08-07T19:37:31.000+0000 |
|---|
Description
iOS and Android report platform-specific values that allow us to determine whether we are dealing with a screen size that would be classified as "tablet" vs. "handheld". Blackberry should do the same. Right now Alloy is using its fallback isTablet check which may not accurately represent the BB device, and at this point, doesn't.
Attachments
isTablethas been hard-coded tofalseas per [~rmcmahon] instructions in TIMOB-13225. PR: https://github.com/appcelerator/alloy/pull/196 test app: https://github.com/appcelerator/alloy/tree/master/test/apps/advanced/form_factor *NOTE:* You can ignore the failed unit tests when running this app on Blackberry. They are unrelated to this ticket. Functional testing should be confirmed on Blackberry. I launched into the simulator with the following command:Run the form_factor app
Confirm that it loads without error and looks like the attached screenshot
Verified displaying and behaving as expected. Titanium SDK 3.1.2.v20130806034554 Alloy 1.2.0-alpha6 Appcelerator Studio 3.1.2.201308021524 CLI 3.1.1 Node 0.10.13 Closing.