Titanium

[ALOY-588] Implement and test isTablet and isHandheld functions for Blackberry

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2013-07-24T16:34:21.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.2.0, 2013 Sprint 15
ComponentsRuntime, Styling
Labelsqe-testadded
ReporterTony Lukasavage
AssigneeTony Lukasavage
Created2013-03-26T17:10:53.000+0000
Updated2013-08-07T19:37:31.000+0000

Description

iOS and Android report platform-specific values that allow us to determine whether we are dealing with a screen size that would be classified as "tablet" vs. "handheld". Blackberry should do the same. Right now Alloy is using its fallback isTablet check which may not accurately represent the BB device, and at this point, doesn't.

Attachments

FileDateSize
Screen Shot 2013-07-24 at 12.28.22 PM.png2013-07-24T16:35:45.000+000023111

Comments

  1. Tony Lukasavage 2013-07-24 isTablet has been hard-coded to false as per [~rmcmahon] instructions in TIMOB-13225. PR: https://github.com/appcelerator/alloy/pull/196 test app: https://github.com/appcelerator/alloy/tree/master/test/apps/advanced/form_factor *NOTE:* You can ignore the failed unit tests when running this app on Blackberry. They are unrelated to this ticket. Functional testing should be confirmed on Blackberry. I launched into the simulator with the following command: 
       ti build -p blackberry -T simulator -A 192.168.150.129 -n /Applications/bbndk

    Run the form_factor app

    Confirm that it loads without error and looks like the attached screenshot

  2. Federico Casali 2013-08-07 Verified displaying and behaving as expected. Titanium SDK 3.1.2.v20130806034554 Alloy 1.2.0-alpha6 Appcelerator Studio 3.1.2.201308021524 CLI 3.1.1 Node 0.10.13 Closing.

JSON Source