Titanium JIRA Archive
Alloy (ALOY)

[ALOY-748] Alloy code should pass cleanly through jslint

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2013-07-17T19:38:15.000+0000
Affected Version/sn/a
Fix Version/sAlloy 1.2.0, 2013 Sprint 15
ComponentsRuntime
Labelsqe-testadded
ReporterTony Lukasavage
AssigneeTony Lukasavage
Created2013-07-17T12:32:57.000+0000
Updated2013-08-02T02:11:52.000+0000

Description

All Javascript code in Alloy should pass through jslint without errors. The only exceptions to this rile should be builtins or other JS code that is managed by external authors.

exclusion

* non-Appcelerator builtins (i.e, moment.js, backbone.js, etc...) * generated JS files (i.e., tss.js TSS grammar file) * jasmine.js from the "test/lib" folder * apps in the "test/app/testing" folder

other notes

There are a few exceptions that will be handled later in jslint as well. In particular a few of the following "errors" will cause arguably less readability in the code: * Redefinition of NAME (simply when assigning a module require to a variable) * Don't make functions within a loop (no anonymous functions with underscore in loops?!)

Comments

  1. Tony Lukasavage 2013-07-17

    PR: https://github.com/appcelerator/alloy/pull/183 These were coding standard changes. Functional testing can be confirmed simply by all automated unit tests passing.
    jake test:all
  2. Federico Casali 2013-08-02

    Verified as working with automatic unit test passing. Closing.

JSON Source