[ALOY-748] Alloy code should pass cleanly through jslint
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-07-17T19:38:15.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.2.0, 2013 Sprint 15 |
| Components | Runtime |
| Labels | qe-testadded |
| Reporter | Tony Lukasavage |
| Assignee | Tony Lukasavage |
| Created | 2013-07-17T12:32:57.000+0000 |
| Updated | 2013-08-02T02:11:52.000+0000 |
Description
All Javascript code in Alloy should pass through jslint without errors. The only exceptions to this rile should be builtins or other JS code that is managed by external authors.exclusion
* non-Appcelerator builtins (i.e, moment.js, backbone.js, etc...) * generated JS files (i.e., tss.js TSS grammar file) * jasmine.js from the "test/lib" folder * apps in the "test/app/testing" folderother notes
There are a few exceptions that will be handled later in jslint as well. In particular a few of the following "errors" will cause arguably less readability in the code: * Redefinition of NAME (simply when assigning a module require to a variable) * Don't make functions within a loop (no anonymous functions with underscore in loops?!)Comments
- Tony Lukasavage 2013-07-17
PR: https://github.com/appcelerator/alloy/pull/183
These were coding standard changes. Functional testing can be confirmed simply by all automated unit tests passing.
jake test:all
- Federico Casali 2013-08-02 Verified as working with automatic unit test passing. Closing.