[ALOY-801] Not properly cleaning up platform-specific orphan files
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2013-08-20T18:07:25.000+0000 |
Affected Version/s | Alloy 1.2.2 |
Fix Version/s | Alloy 1.3.0 |
Components | Tooling |
Labels | n/a |
Reporter | Tony Lukasavage |
Assignee | Tony Lukasavage |
Created | 2013-08-20T17:00:23.000+0000 |
Updated | 2013-10-14T21:29:27.000+0000 |
Description
Comments
- Tony Lukasavage 2013-08-20
PR: https://github.com/appcelerator/alloy/pull/230
test app: https://github.com/appcelerator/alloy/tree/master/test/apps/models/todo
make sure your log level is set to TRACE (default on CLI)
Run the app
compile the app again. You should see no files removed the "CLEANING RESOURCES" section of the log
Prior to this fix, if you followed the above steps for ios, you would get the following log indicating that files were designated as "orphan" incorrectly:[DEBUG] ----- CLEANING RESOURCES ----- [DEBUG] Removing orphaned controllers... [DEBUG] Removing orphaned models... [DEBUG] Removing orphaned styles... [DEBUG] Removing orphaned sync adapters... [DEBUG] Removing orphaned assets and libs... [DEBUG] [DEBUG] ----- BASE RUNTIME FILES -----
While this wouldn't impact the app as the files would simply be copied back in, it is inefficient and could potentially impact the speed at which incremental compiles (ALOY-757) would be executed.[DEBUG] ----- CLEANING RESOURCES ----- [DEBUG] Removing orphaned controllers... [DEBUG] Removing orphaned models... [DEBUG] Removing orphaned styles... [DEBUG] Removing orphaned sync adapters... [DEBUG] Removing orphaned assets and libs... [TRACE] * iphone/ConsoleReporter.js [TRACE] * iphone/colors.js [TRACE] * iphone/ic_menu_add.png [TRACE] * iphone/jasmine.js [TRACE] * iphone/red_x.png [TRACE] * iphone/runtimeTester.js [TRACE] * iphone/tick_64.png [TRACE] * iphone/tick_gray_64.png [DEBUG]
- Federico Casali 2013-10-14 Verified fixed. No files are shown in the CLEANING RESOURCES process. TiSDK 3.2.0.v20131013140318 Alloy 1.3.0 CLI 3.2.0 Closing.