[ALOY-816] Add deprecation for Ti.UI.iPhone.NavigationGroup, minimum version validation for Ti.UI.iOS.NavigationWindow
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-09-04T15:31:37.000+0000 |
| Affected Version/s | Alloy 1.2.2 |
| Fix Version/s | Alloy 1.3.0, 2013 Sprint 18 |
| Components | XML |
| Labels | n/a |
| Reporter | Tony Lukasavage |
| Assignee | Tony Lukasavage |
| Created | 2013-09-04T02:41:01.000+0000 |
| Updated | 2013-10-14T22:25:09.000+0000 |
Description
Add a deprecation warning to any usage of Ti.UI.iPhone.NavigationGroup if the TiSDK is >= 3.1.3
Throw compile error if a developer attempts to use the Ti.UI.iOS.NavigationWindow markup in an app using TiSDK version < 3.1.3
Comments
- Timan Rebel 2013-09-04 Shouldn't the Ti.UI.iOS.NavigationGroup in 2. be Ti.UI.iOS.NavigationWindow?
- Tony Lukasavage 2013-09-04 [~timanrebel] yep, fixed.
- Tony Lukasavage 2013-09-04
PR: https://github.com/appcelerator/alloy/pull/238
test apps:
https://github.com/appcelerator/alloy/tree/master/test/apps/ui/navgroup
https://github.com/appcelerator/alloy/tree/master/test/apps/ui/navwindow
Functional tests (ios only):ui/navgroup with TiSDK < 3.1.3
Run the ui/navgroup with a TiSDK version < 3.1.3
Ensure that you get no warnings during compile and that it runs successfully
ui/navwindow with TiSDK < 3.1.3
Run the ui/navwindow with a TiSDK version < 3.1.3
Ensure that you get a compile time error that looks like this:
[INFO] ----- MVC GENERATION ----- [INFO] [app.tss] global style processing... [INFO] [index.xml] view processing... [INFO] style: "index.tss" [INFO] view: "ios/index.xml" [ERROR] Ti.UI.iOS.NavigationWindow (line 2) requires Titanium 3.1.3+ [ERROR] Alloy compiler failed
ui/navgroup with TiSDK >= 3.1.3
Switch ui/navgroup to use Titanium SDK version >= 3.1.3 and run the app
You should see a warning message like this:
[INFO] ----- MVC GENERATION ----- [INFO] [app.tss] global style processing... [INFO] [index.xml] view processing... [INFO] style: "index.tss" [INFO] view: "ios/index.xml" [WARN] Ti.UI.iPhone.NavigationGroup (line 3) is deprecated as of Titanium 3.1.3 [WARN] Use Ti.UI.iOS.NavigationWindow instead
The app should still run as expected even with the warning message during compile
ui/navwindow with TiSDK >= 3.1.3
Switch to ui/navwindow with Titanium SDK version >= 3.1.3 and run the app
The app should run without error, executing with the new NavigationWindow
- Federico Casali 2013-10-14 Verified working as expected. TiSDK 3.2.0.v20131013140318 Alloy 1.3.0 CLI 3.2.0 Closing.