[ALOY-887] In XML files of an Alloy project, open a comment block but not closing it, will hang up the compiler

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2014-02-04T20:54:58.000+0000
Affected Version/s	n/a
Fix Version/s	Alloy 1.4.0
Components	XML
Labels	qe-testadded, supportTeam
Reporter	Mauro Parra-Miranda
Assignee	Tim Poulsen
Created	2013-11-21T15:16:11.000+0000
Updated	2014-05-13T23:50:21.000+0000

Description

The compiler will start compilation but will remain in the XML file forever. In the Studio you will not see any error. If you compile it manually in the command line, you will see in which specific file is "freezed", but again no error. Example:

Comments

Tim Poulsen 2014-01-22

This behavior is caused by an issue with the xmldom module upon which Alloy depends. See https://github.com/jindw/xmldom/issues/68 Also possibly related would be https://github.com/jindw/xmldom/issues/40
Tim Poulsen 2014-01-22

I've submitted a pull request to the xmldom project that fixes this error. https://github.com/jindw/xmldom/pull/74

Tony Lukasavage 2014-02-04

PR: https://github.com/appcelerator/alloy/pull/323 test app: https://github.com/appcelerator/alloy/tree/master/test/apps/testing/ALOY-887 Functional test should include running the test app above and confirming that it generates a compile time error that looks like this:

   [DEBUG] [INFO]  ----- MVC GENERATION -----
   [DEBUG] [INFO]  [global style] writing to cache...
   [DEBUG] [INFO]  [index.xml] view processing...
   [DEBUG] [INFO]    style:      "index.tss"
   [DEBUG] [INFO]    view:       "index.xml"
   [DEBUG] [ERROR] Error parsing XML file.
   [DEBUG] [ERROR] Unclosed comment
   [DEBUG] [ERROR] @#[line:4,col:3]
   [DEBUG] [ERROR] Alloy compiler failed

Federico Casali 2014-05-13

Verified as fixed. TiSDK 3.3.0.v20140513115438 Alloy 1.4.0-dev Appcelerator Studio 3.3.0.201405011408 CLI 3.3.0-dev Closing.

JSON Source