Titanium

[ALOY-937] Platform specific widget assets are misplaced under Resources

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2014-01-27T16:07:07.000+0000
Affected Version/sAlloy 1.3.1
Fix Version/sAlloy 1.4.0, Alloy 1.3.1, 2014 Sprint 02
ComponentsWidgets
Labelsalloy, assets, community, compile, platforms, qe-manualtest, triage, widgets
ReporterFokke Zandbergen
AssigneeTony Lukasavage
Created2014-01-23T11:06:21.000+0000
Updated2014-11-20T22:14:40.000+0000

Description

There happens to be a regression with platform specific widget assets since Alloy 1.3 started compiling to platform specific folders under Resources.

To reproduce

1. Compile the attached Alloy app for iOS or Android. 2. Find that main assets are well placed. 3. Find that the widget assets are misplaced under Resources/android/iphone and alike folders.

Attachments

FileDateSize
ALOY-937_sample.zip2014-02-05T19:02:46.000+00006154072
app.zip2014-01-23T11:06:21.000+000069763
app (3).zip2014-01-24T17:29:07.000+0000152845
Untitled.tiff2014-01-23T20:49:59.000+0000231790

Comments

  1. Ritu Agrawal 2014-01-24 Moving this ticket to engineering as we can reproduce it with the provided steps.
  2. Fokke Zandbergen 2014-01-24
  3. Tony Lukasavage 2014-01-24 app(3) is an updated app with details related to android density specific images
  4. Fokke Zandbergen 2014-01-24 The issue described is not critical, but using density-specific folders under widget assets is as the next test shows: https://www.flowdock.com/rest/private/11188/37372/files/2IqZkjLWhNarR71S75Jkig/app.zip Compile for Android and you'll find Resources/android/android and Resources/android/iphone folders that shouldn't been there and the density specific widget assets can only be found under Resources/android/android.
  5. Tony Lukasavage 2014-01-25 PR: https://github.com/appcelerator/alloy/pull/310 test app: https://github.com/appcelerator/alloy/tree/master/test/apps/testing/ALOY-937 Functional test

    Compile the test app (same as the one in the description) for android and/or ios

    Ensure that the file assets for the compile are copied to the right locations. For example, make sure that if you first compile for android that no "Resources/android/iphone" folder is created. Also ensure that the density-specific images for the widget are copied to the appropriate locations. For reference, I have attached a screenshot of what the resulting file structure should look like for a fresh android compile of the test app.

  6. Tony Lukasavage 2014-01-25 [~fokke] would you be so kind as to test with the following version of alloy and make sure that your bug is fixed? 
       npm install -g git://github.com/appcelerator/alloy.git#1_3_X
    Soon as you do, I'll resolve this ticket and post a new beta to npm.
  7. Fokke Zandbergen 2014-01-25 [~tlukasavage], the only thing I've found is that there's an empty Resources/iphone|android/foo directory, but that's not a problem of course. Another thing not related to assets is that only when compiling to iOS, there is a Resources/alloy/CFG.js, duplicating Resources/iphone/alloy/CFG.js. Again, not really a problem, just noticed it. Also, what is the reason for having an empty Resources/app.js? Some kind of backwards compatibility thing? Seems to work well without.
  8. Jeff Antram 2014-01-27 Platform specific widget assets are in the right place now. But I am seeing a populated Resources/iphone/images folder for an android build and vice versa for an iPhone build.
  9. Tony Lukasavage 2014-01-27 Thanks guys! I'm going to resolve this issue to take care of the regression, but I'll log a new ticket for more cleanly populating the assets throughout the rest of the platform-specific folders.
  10. Tony Lukasavage 2014-01-27 Merged into both master and 1_3_X. Available in alloy 1.3.1-beta4.

JSON Source