[ALOY-953] Alloy Social.js builtin: improve UI for both iOS 7 and Android
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2014-02-07T16:00:53.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.4.0 |
| Components | Builtins |
| Labels | alloy, qe-testadded, social.js, twitter |
| Reporter | Martin Tietz |
| Assignee | Tim Poulsen |
| Created | 2014-02-07T07:53:09.000+0000 |
| Updated | 2014-05-13T17:51:13.000+0000 |
Description
There are multiple issues with the UI of the Twitter popup on both iOS 7 and Android (using Titanium >= 3.2.0).
I already opened a pull request that shows some screenshots of the mentioned issues and includes some changes to alloy/builtins/social.js in order to fix those UI problems: https://github.com/appcelerator/alloy/pull/299
Attachments
| File | Date | Size |
|---|---|---|
| app.zip | 2014-02-07T14:11:17.000+0000 | 5901229 |
Test app attached
PR: https://github.com/appcelerator/alloy/pull/299 Functional test: 1) Create a new project 2) Replace its app folder with the attached. 3) Update controllers/index.js with valid Twitter API consumer secret and consumer key values 4) Build for iOS 5) Enter a message in the text box and tap Tweet 6) Observe that the authorization overlay doesn't cover the status bar, "X" close button doesn't cover Sign Up For Twitter link. 7) Built for Android, then enter a message in the text box and tap Tweet 8) Observe that the overlay extends atop the action bar, no navigation (title) bar is displayed for the overlay, loading bar (if it appears) is vertically centered)
PR merged, functional test in preceding comments