[ALOY-963] Allow platform specific subfolders in lib and vendor directories
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2014-09-04T18:04:31.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Alloy 1.5.0 |
| Components | Tooling |
| Labels | alloy, qe-3.4.0, qe-manualtest |
| Reporter | John Nguyen |
| Assignee | Feon Sua Xin Miao |
| Created | 2014-02-27T01:35:56.000+0000 |
| Updated | 2014-09-05T23:08:08.000+0000 |
Description
Platform specific folders (iphone,android,etc.) in the app/lib and app/vendor directories were not compiling to Resources correctly. The following pull request will fix this.
https://github.com/appcelerator/alloy/pull/337
Attachments
| File | Date | Size |
|---|---|---|
| android.png | 2014-06-18T08:37:02.000+0000 | 67949 |
| iphone.png | 2014-06-18T08:37:02.000+0000 | 64633 |
| mobileweb.png | 2014-06-18T08:37:02.000+0000 | 82113 |
Thank you for submitting the pull request. We need a simple runnable test case that demonstrates that Platform specific folders (iphone,android,etc.) in the app/lib and app/vendor directories were not compiling to Resources correctly. We would then use that test case to evaluate the PR.
Jake tests fail for ALOY-887 app. When tested with jake app:run, the compiler goes into an infinite loop. Rest of the tests pass. Test case app and signed CLA are still needed, even after this failure is addressed.
CLA has been signed
PR: https://github.com/appcelerator/alloy/pull/454 Test app: https://github.com/feons/alloy/tree/ALOY-963/test/apps/testing/ALOY-963 Functional Test: 1. Compile the test app on multiple platforms 2. The UI and alert message should match the attached screenshots respectively 3. On iphone : blue box, click on the label, alert shows "clicked iphone" 4. On android : yellow box, click on the label, alert shows "clicked android" 5. On other platforms : green box, click on the label, alert shows "clicked"
PR tested and merged.
Verified working as expected on iPhone 5 iOS 7.1.2, Android Galaxy Nexus 4.3 and MobileWeb TiSDK 3.4.0.v20140813022514 Appcelerator Studio 3.3.1.201408121314 CLI 3.4.0-dev Alloy 1.5.0-dev Xcode6-beta5 Closing.
I agree--we should move to "ios" as a standard name.
Note that the PR submitted for ALOY-1122 should re-resolve this ticket.
PR to update the ALOY-963 test app to use the new folder name (ios, not iphone) https://github.com/appcelerator/alloy/pull/542 (1_5_X) https://github.com/appcelerator/alloy/pull/543 (master)
Approved and merged.