Titanium JIRA Archive
Appcelerator Daemon (DAEMON)

[DAEMON-157] appcd: Suppress banner when run through appc

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusResolved
ResolutionFixed
Resolution Date2017-11-16T22:22:38.000+0000
Affected Version/sAppc Daemon 1.0.0
Fix Version/sAppc Daemon 1.0.0
Componentsappcd
Labelsn/a
ReporterEwan Harris
AssigneeChris Barber
Created2017-11-16T21:46:18.000+0000
Updated2017-11-17T00:15:33.000+0000

Description

Description

It was raised that the double banner when running appc appcd shouldn't happen, we should suppress this, I think we can use the APPC_ENV environment variable to do so, alternatively we could have the CLI push a --no-banner flag but I prefer the former

Comments

  1. Ewan Harris 2017-11-16

    [~cbarber] Are you good with this change? I'll fold in with DAEMON-129 if so
  2. Chris Barber 2017-11-16

    Agreed. If the APPC_ENV is defined, appcd will suppress the banner.
  3. Ewan Harris 2017-11-16

    Eurgh, sorry [~cbarber] that doesn't seem to be taking on my Windows machine. Shall we add process.env.APPC_ENV = true; to appc-cli here [here](https://github.com/appcelerator/appc-cli/blob/8594e625681243c21e28fb242ce7501f13223258/bin/commands/appcd.js#L32) for simplicity?
  4. Chris Barber 2017-11-17

    How about process.env.hasOwnProperty('APPC_ENV')?
  5. Chris Barber 2017-11-17

    Fixed https://github.com/appcelerator/appc-daemon/pull/158

JSON Source