Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-27126] iOS 13: Support dark mode

GitHub Issuen/a
TypeNew Feature
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2019-09-09T10:17:49.000+0000
Affected Version/sn/a
Fix Version/sRelease 8.2.0
Componentsn/a
Labelsn/a
ReporterVijay Singh
AssigneeEwan Harris
Created2019-06-03T23:48:01.000+0000
Updated2019-09-10T16:26:58.000+0000

Description

Apple announced dark mode in iOS 13. Look for apis to support in SDK. WWDC 2019 video for dark mode support - https://developer.apple.com/videos/play/wwdc2019/214/

Comments

  1. Hans Knöchel 2019-06-04

    Dark mode is made via the asset catalog. Having semantic colors and images is the key here. I have a local plugin running that could even generate this cross platform, so maybe it could be a an SDK extension as well.
  2. Hans Knöchel 2019-06-05

    Required CLI hook + native bridge: https://github.com/hansemannn/titanium-dark-mode Pull request: https://github.com/appcelerator/titanium_mobile/pull/10937 The CLI hook and bridge could eventually be moved to the SDK, but this way it's a bit more flexible for developers right now.
  3. Ewan Harris 2019-07-31

    master: https://github.com/appcelerator/titanium_mobile/pull/11097
  4. Keerthi Mahalingam 2019-09-03

    FR passed. tested with the sample app here .https://github.com/ewanharris/darkmode-example. PR #10937 is merged. waiting on Jenkins for other PR
  5. Keerthi Mahalingam 2019-09-03

    PR merged
  6. Samir Mohammed 2019-09-05

    Verified feature in SDK version 8.2.0.v20190904142953. One thing I noticed is that images on the tabGroup do not change automatically when switching from light and dark mode unlike an imageVIew do, to see the image change on the tabGroup an app restart is needed. Is this an intended [~eharris]?.
  7. Vijay Singh 2019-09-06

    [~smohammed] It's not intended. Let me check on this.
  8. Vijay Singh 2019-09-06

    [~kmahalingam] [~smohammed] PR for above fix - PR - https://github.com/appcelerator/titanium_mobile/pull/11200
  9. Keerthi Mahalingam 2019-09-06

    FR passed.
  10. Samir Mohammed 2019-09-09

    *Closing ticket* New feature verified in SDK version 8.2.0.v20190906140307. Test and other information can be found at: https://github.com/appcelerator/titanium_mobile/pull/11200 https://github.com/appcelerator/titanium_mobile/pull/10937 https://github.com/hansemannn/titanium-dark-mode https://github.com/ewanharris/darkmode-example
  11. Hans Knöchel 2019-09-10

    A few remaining questions for parity: 1. Does it handle the alpha fallback for iOS < 13 and Android already, e.g. the ARGB conversion? 2. Are there plans to properly support Android, e.g. the userInterfaceStyle property?

JSON Source