[TIMOB-674] Android: TableViewRow height not working.
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2011-04-17T01:53:52.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 1.2.0 |
Components | Android |
Labels | android, defect |
Reporter | Don Thorp |
Assignee | Marshall Culpepper |
Created | 2011-04-15T02:34:10.000+0000 |
Updated | 2011-04-17T01:53:52.000+0000 |
(from [363df2843cbbb4a3037105a2bbf900606027fba9]) added "height" support to row proxies [#674 state:resolved] http://github.com/appcelerator/titanium_mobile/commit/363df2843cbbb4a3037105a2bbf900606027fba9"> http://github.com/appcelerator/titanium_mobile/commit/363df2843cbbb...
you sure the content measuring stuff works?....
h = Math.max(h, Math.max(content.getMeasuredHeight(), Math.max(leftImageHeight, rightImageHeight)));
given your fix (that height overrides the above), then should I have expected my row to have been resized, before this fix?
I have a row with an images and some lables etc, the row was never sized to fit them.
Is that a different defect - as this is specifically a fix to include support for height?
Hey Dan.. looks like I may've misunderstood the purpose of this bug. If the row isn't growing correctly to the content size of your images/labels, then that would be a bug in the way that "auto" works. Are you explicitly setting width/height for those rows to a static number, or just "auto" (which is the default)?
No you understood this bug well enough... setting an explicit height had no effect.
My comment above was made because when I saw the implementation of your fix it became clear to me that the existing code should have resized the row 'auto'matically by default (I wasn't really aware of this before). I remembered that it wasn't resizing with 'auto' before.
So yes there are two bugs (the second one I only became aware of after reviewing your fix for the first)
hmm - latest pull from HEAD looks like 'auto' is behaving better, possibly correctly - perhaps there is no second bug. could I have been seeing auto fail because i only copied over the ui jar.